-
Notifications
You must be signed in to change notification settings - Fork 60
feat: add cron module #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ZuluSpl0it
wants to merge
5
commits into
classic-terra:main
Choose a base branch
from
ZuluSpl0it:feature/add-cron-v4.0.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d1a1209
feat: add cron module
ZuluSpl0it 66e6757
feat: update cron module behavior
ZuluSpl0it b6558a1
fix: capture cron execution panics
ZuluSpl0it 3106aa5
fix: format cron imports
ZuluSpl0it ad9c334
fix: register app simulation flags
ZuluSpl0it File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,149 @@ | ||
| package app_test | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
| "time" | ||
|
|
||
| sdkmath "cosmossdk.io/math" | ||
| wasmtypes "github.com/CosmWasm/wasmd/x/wasm/types" | ||
| "github.com/classic-terra/core/v4/app" | ||
| appparams "github.com/classic-terra/core/v4/app/params" | ||
| helpers "github.com/classic-terra/core/v4/app/testing" | ||
| coretypes "github.com/classic-terra/core/v4/types" | ||
| "github.com/classic-terra/core/v4/x/cron/types" | ||
| dyncommtypes "github.com/classic-terra/core/v4/x/dyncomm/types" | ||
| markettypes "github.com/classic-terra/core/v4/x/market/types" | ||
| oracletypes "github.com/classic-terra/core/v4/x/oracle/types" | ||
| taxtypes "github.com/classic-terra/core/v4/x/tax/types" | ||
| treasurytypes "github.com/classic-terra/core/v4/x/treasury/types" | ||
| abci "github.com/cometbft/cometbft/abci/types" | ||
| tmproto "github.com/cometbft/cometbft/proto/tendermint/types" | ||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| authtypes "github.com/cosmos/cosmos-sdk/x/auth/types" | ||
| banktypes "github.com/cosmos/cosmos-sdk/x/bank/types" | ||
| distrtypes "github.com/cosmos/cosmos-sdk/x/distribution/types" | ||
| minttypes "github.com/cosmos/cosmos-sdk/x/mint/types" | ||
| stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| type appCronWasmMsgServer struct { | ||
| calls []*wasmtypes.MsgExecuteContract | ||
| } | ||
|
|
||
| func (s *appCronWasmMsgServer) ExecuteContract(_ context.Context, msg *wasmtypes.MsgExecuteContract) (*wasmtypes.MsgExecuteContractResponse, error) { | ||
| s.calls = append(s.calls, msg) | ||
| return &wasmtypes.MsgExecuteContractResponse{}, nil | ||
| } | ||
|
|
||
| func initCronAppState(t *testing.T, terraApp *app.TerraApp, ctx sdk.Context) { | ||
| t.Helper() | ||
|
|
||
| terraApp.ConsensusParamsKeeper.ParamsStore.Set(ctx, *helpers.DefaultConsensusParams) | ||
| terraApp.MintKeeper.Params.Set(ctx, minttypes.DefaultParams()) | ||
| terraApp.MintKeeper.Minter.Set(ctx, minttypes.DefaultInitialMinter()) | ||
|
|
||
| taxParams := taxtypes.DefaultParams() | ||
| taxParams.GasPrices = sdk.NewDecCoins(sdk.NewDecCoin(coretypes.MicroSDRDenom, sdkmath.ZeroInt())) | ||
| require.NoError(t, terraApp.TaxKeeper.SetParams(ctx, taxParams)) | ||
|
|
||
| bankParams := banktypes.DefaultParams() | ||
| bankParams.DefaultSendEnabled = true | ||
| require.NoError(t, terraApp.BankKeeper.SetParams(ctx, bankParams)) | ||
| terraApp.BankKeeper.SetSendEnabled(ctx, "uluna", true) | ||
|
|
||
| stakingParams := stakingtypes.DefaultParams() | ||
| stakingParams.BondDenom = appparams.BondDenom | ||
| require.NoError(t, terraApp.StakingKeeper.SetParams(ctx, stakingParams)) | ||
| terraApp.DistrKeeper.Params.Set(ctx, distrtypes.DefaultParams()) | ||
| terraApp.DistrKeeper.FeePool.Set(ctx, distrtypes.InitialFeePool()) | ||
| terraApp.WasmKeeper.SetParams(ctx, wasmtypes.DefaultParams()) | ||
| terraApp.MarketKeeper.SetParams(ctx, markettypes.DefaultParams()) | ||
| terraApp.OracleKeeper.SetParams(ctx, oracletypes.DefaultParams()) | ||
| terraApp.TreasuryKeeper.SetParams(ctx, treasurytypes.DefaultParams()) | ||
| terraApp.DyncommKeeper.SetParams(ctx, dyncommtypes.DefaultParams()) | ||
| } | ||
|
|
||
| type appBlockModule interface { | ||
| BeginBlock(context.Context) ([]abci.ValidatorUpdate, error) | ||
| EndBlock(context.Context) ([]abci.ValidatorUpdate, error) | ||
| } | ||
|
|
||
| func TestCronModuleWiredIntoApp(t *testing.T) { | ||
| terraApp := helpers.SetupApp(t, "cron-test") | ||
|
|
||
| require.Contains(t, terraApp.Modules(), types.ModuleName) | ||
| require.NotNil(t, terraApp.CronKeeper.WasmMsgServer) | ||
| require.True(t, terraApp.ModuleAccountAddrs()[authtypes.NewModuleAddress(types.ModuleName).String()]) | ||
| } | ||
|
|
||
| func TestCronExecutesInBeginBlock(t *testing.T) { | ||
| terraApp := helpers.SetupApp(t, "cron-test") | ||
| fakeServer := &appCronWasmMsgServer{} | ||
| terraApp.CronKeeper.WasmMsgServer = fakeServer | ||
|
|
||
| ctx := terraApp.NewUncachedContext(false, tmproto.Header{ChainID: "cron-test"}) | ||
| ctx = ctx.WithBlockHeight(9).WithBlockTime(time.Now().UTC()) | ||
| initCronAppState(t, terraApp, ctx) | ||
|
|
||
| require.NoError(t, terraApp.CronKeeper.SetParams(ctx, types.NewParams(1))) | ||
| require.NoError(t, terraApp.CronKeeper.AddSchedule( | ||
| ctx, | ||
| "begin-job", | ||
| 1, | ||
| []types.MsgExecuteContract{{Contract: "terra1contract", Msg: `{"ping":{}}`}}, | ||
| 9, | ||
| types.ExecutionStage_EXECUTION_STAGE_BEGIN_BLOCKER, | ||
| )) | ||
|
|
||
| execCtx := terraApp.NewUncachedContext(false, tmproto.Header{ChainID: "cron-test"}) | ||
| execCtx = execCtx.WithBlockHeight(10).WithBlockTime(time.Now().UTC()) | ||
| require.Equal(t, int64(10), execCtx.BlockHeight()) | ||
|
|
||
| // Use the app-registered cron module instance so the test exercises the module | ||
| // exactly as Terra wires it into the app. | ||
| cronModule := terraApp.Modules()[types.ModuleName].(appBlockModule) | ||
| _, err := cronModule.BeginBlock(sdk.WrapSDKContext(execCtx)) | ||
| require.NoError(t, err) | ||
| require.Len(t, fakeServer.calls, 1) | ||
|
|
||
| schedule, found := terraApp.CronKeeper.GetSchedule(execCtx, "begin-job") | ||
| require.True(t, found) | ||
| require.Equal(t, uint64(10), schedule.LastExecuteHeight) | ||
| } | ||
|
|
||
| func TestCronExecutesInEndBlock(t *testing.T) { | ||
| terraApp := helpers.SetupApp(t, "cron-test") | ||
| fakeServer := &appCronWasmMsgServer{} | ||
| terraApp.CronKeeper.WasmMsgServer = fakeServer | ||
|
|
||
| ctx := terraApp.NewUncachedContext(false, tmproto.Header{ChainID: "cron-test"}) | ||
| ctx = ctx.WithBlockHeight(10).WithBlockTime(time.Now().UTC()) | ||
| initCronAppState(t, terraApp, ctx) | ||
|
|
||
| require.NoError(t, terraApp.CronKeeper.SetParams(ctx, types.NewParams(1))) | ||
| require.NoError(t, terraApp.CronKeeper.AddSchedule( | ||
| ctx, | ||
| "end-job", | ||
| 1, | ||
| []types.MsgExecuteContract{{Contract: "terra1contract", Msg: `{"pong":{}}`}}, | ||
| 10, | ||
| types.ExecutionStage_EXECUTION_STAGE_END_BLOCKER, | ||
| )) | ||
|
|
||
| execCtx := terraApp.NewUncachedContext(false, tmproto.Header{ChainID: "cron-test"}) | ||
| execCtx = execCtx.WithBlockHeight(11).WithBlockTime(time.Now().UTC()) | ||
| require.Equal(t, int64(11), execCtx.BlockHeight()) | ||
|
|
||
| // Use the app-registered cron module instance so the test exercises the module | ||
| // exactly as Terra wires it into the app. | ||
| cronModule := terraApp.Modules()[types.ModuleName].(appBlockModule) | ||
| _, err := cronModule.EndBlock(sdk.WrapSDKContext(execCtx)) | ||
| require.NoError(t, err) | ||
| require.Len(t, fakeServer.calls, 1) | ||
|
|
||
| schedule, found := terraApp.CronKeeper.GetSchedule(execCtx, "end-job") | ||
| require.True(t, found) | ||
| require.Equal(t, uint64(11), schedule.LastExecuteHeight) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package app_test | ||
|
|
||
| import ( | ||
| "flag" | ||
|
|
||
| simcli "github.com/cosmos/cosmos-sdk/x/simulation/client/cli" | ||
| ) | ||
|
|
||
| func init() { | ||
| if flag.Lookup("Enabled") == nil { | ||
| simcli.GetSimulatorFlags() | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| syntax = "proto3"; | ||
| package terra.cron.v1; | ||
|
|
||
| import "gogoproto/gogo.proto"; | ||
| import "terra/cron/v1/params.proto"; | ||
| import "terra/cron/v1/schedule.proto"; | ||
|
|
||
| option go_package = "github.com/classic-terra/core/v4/x/cron/types"; | ||
|
|
||
| message GenesisState { | ||
| Params params = 1 [(gogoproto.nullable) = false]; | ||
| repeated Schedule schedule_list = 2 [(gogoproto.nullable) = false]; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| syntax = "proto3"; | ||
| package terra.cron.v1; | ||
|
|
||
| import "amino/amino.proto"; | ||
| import "cosmos_proto/cosmos.proto"; | ||
| import "gogoproto/gogo.proto"; | ||
|
|
||
| option go_package = "github.com/classic-terra/core/v4/x/cron/types"; | ||
|
|
||
| message Params { | ||
| uint64 limit = 1; | ||
| uint64 max_execution_gas = 2; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.