🍕 Hydrate process.env before Vite universal modules evaluate#246
Merged
Conversation
Generate a shared .clay/_env-init.js runtime module and import it first from both Vite entries (view bootstrap and kiln-edit init). This hydrates window.process.env from the earliest available runtime source (window.kiln.preloadData._envVars when present, otherwise existing window.process.env) before component/model modules execute. Fixes timing-sensitive cases where top-level universal constants like `const AGORA_HOST = process.env.AGORA_HOST` were evaluated before env injection and permanently captured undefined/null values. Made-with: Cursor
|
coverage: 63.968% (-0.09%) from 64.054% — jordan/fix-vite-env-hydration-order into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.clay/_env-init.js..clay/vite-bootstrap.js(view mode).clay/vite-kiln-edit-init.js(edit mode)window.kiln.preloadData._envVars(when present)window.process.envWhy
Some universal modules cache env values at top-level (e.g.
const AGORA_HOST = process.env.AGORA_HOST). Under ESM/Vite, module evaluation timing can happen before late env injection, causing those constants to permanently captureundefined/nulleven though values appear later onwindow.process.env.By importing
_env-init.jsfirst,window.process.envis hydrated before component/model modules execute.Scope
Test plan
npm run lintnpm test(403 passing)Made with Cursor