fix: remove client-supplied rating, dead code, and deletePrompt rollback - #2
Open
Ahmedfurkhan wants to merge 1 commit into
Open
fix: remove client-supplied rating, dead code, and deletePrompt rollback#2Ahmedfurkhan wants to merge 1 commit into
Ahmedfurkhan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Carey and Julia! Just finished reviewing Prompt Explore and honestly it was a great experience the codebase is really clean and well thought out. The moderation workflow especially stood out, super smart to use a recently_deleted collection instead of hard deleting. I caught a couple of small bugs during the review (fake rating injection on create and a data consistency edge case in deletePrompt) and submitted a fix PR. Overall awesome work, you can tell a lot of effort went into this. Really enjoyed reviewing it!
What changed
routes/create.js
ratingfromreq.bodydestructuring{ 1:0, 2:0, 3:0, 4:0, 5:0 }server-sidedb/promptDB.js
deletePrompt: added rollback ifdeleteOnefails after archivingWhy
These were caught during peer code review. No functional behaviour
changes for the happy path only edge case correctness and security.
Reviewer notes
Future upgrades you can do for the application :
Copy Button
One-click copy on every prompt card. Most-used feature for real users — they come to find a prompt and paste it somewhere.
User Accounts
Right now anyone can delete anything. A simple session-based auth would let you track who submitted what and protect prompts from random deletion.
Prompt History / Versioning
When a moderator edits a prompt, save the original. Let users see what changed and why.