feature: add language server implementation by 16bit-ykiko · Pull Request #18 · clice-io/eventide

16bit-ykiko · 2026-02-17T10:10:13Z

Summary by CodeRabbit

New Features
- Added comprehensive LSP types and serialization support, including enum↔string handling and improved map-key parsing/serialization.
- Added a Python code generator to produce LSP headers from schema files.
- Introduced name-normalization and key/string conversion utilities for consistent protocol formatting.
Chores
- Updated formatter configuration and .gitignore to exclude generated LSP schema artifacts.

coderabbitai · 2026-02-17T10:10:34Z

📝 Walkthrough

Walkthrough

Adds LSP generation and runtime support: a Python LSP schema code generator, new C++ LSP type definitions, comprehensive spelling/map-key utilities, enum-string serialization support, improved map key parsing, and related serializer/deserializer and reflection helpers.

Changes

Cohort / File(s)	Summary
LSP Type Definitions `include/language/ts.h`	Adds LSP public types, optional/nullable helpers, LSPVariant/LSPAny/LSPArray/LSPObject, and primitive/URI aliases.
Code Generator `scripts/lsp_codegen.py`	New CLI Python generator that parses/fetches LSP metaModel JSON and emits a single C++23 header (language::protocol) with ordered structs/enums/aliases and docs.
Name Transformation & Key Handling `include/serde/spelling.h`	Introduces rename policies, enum↔string mapping, map key stringification and parsing, parseable_map_key concept, and low-level ASCII/parse helpers.
Serialization Core & Attributes `include/serde/attrs.h`, `include/serde/serde.h`	Adds enum_string annotation, constructors/assignments for annotate wrapper, integrates enum_string and enum_policy into (de)serialization, and updates map key parsing to use parse_map_key.
Simdjson Serializer/Deserializer `include/serde/simdjson/serializer.h`, `include/serde/simdjson/deserializer.h`	Deserializer: adds invalid_key() to signal invalid map keys. Serializer: delegates map key stringification to `serde::spelling::map_key_to_string` and removes in-class map_key_to_string implementation.
Reflection Utilities `include/reflection/enum.h`	Adds `template<enum_type E> constexpr std::optional<E> enum_value(std::string_view)` for name→enum lookup.
Config & Ignore `.gitignore`, `pixi.toml`	Ignores Python cache and generated schema JSON; excludes `include/language/protocol.h` from clang-format task.

Sequence Diagram(s)

sequenceDiagram
    participant CLI as CLI
    participant Fetcher as SchemaFetcher
    participant Parser as SchemaParser
    participant Generator as Generator
    participant Renderer as TypeRenderer
    participant Writer as FileWriter

    CLI->>Fetcher: fetch_schema(--fetch-schema / --schema)
    Fetcher-->>Parser: raw JSON
    Parser->>Generator: SchemaModel
    Generator->>Generator: build_name_map(), build_node_dependencies()
    Generator->>Generator: topological_order(nodes,deps)
    loop for each node
        Generator->>Renderer: render_type / render_or
        Renderer-->>Generator: C++ type strings
        alt struct
            Generator->>Generator: emit_struct()
        else enum
            Generator->>Generator: emit_enum()
        else alias
            Generator->>Generator: emit_alias()
        end
    end
    Generator->>Writer: make_header(includes, blocks)
    Writer->>Writer: write_file(output_path, content)
    Writer-->>CLI: summary metrics

sequenceDiagram
    participant Serializer as Serializer
    participant Meta as AnnotationMeta
    participant Spelling as SpellingUtil
    participant Output as OutputStream

    Serializer->>Meta: query enum_string & enum_policy
    Meta-->>Serializer: enum_string=true, policy
    Serializer->>Spelling: map_enum_to_string(value, policy)
    Spelling-->>Serializer: string
    Serializer->>Output: write field key/value

    Serializer->>Meta: check map key parseable type
    Meta-->>Serializer: parseable_map_key<Key>
    Serializer->>Spelling: map_key_to_string(key)
    Spelling-->>Serializer: stringified key
    Serializer->>Output: write key-value pair

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

feature: add basic async implementation #4 — Adds enum-name/reflection helpers; closely related to the new enum_value and enum-string mapping utilities.

Poem

🐇 I hopped through JSON fields in the night,
Generated types with nimble delight.
Enums now speak in polished string,
Keys parse true — what joy they bring!
A little rabbit stamped: protocol takes flight.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 2.56% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'feature: add language server implementation' directly aligns with the primary changes in the PR, which introduce comprehensive LSP support infrastructure including type definitions, serialization/deserialization utilities, and code generation tooling.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch language-server-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

fmt