Potential fix for code scanning alert no. 2: Incomplete string escaping or encoding#16
Draft
cliffano wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 2: Incomplete string escaping or encoding#16cliffano wants to merge 1 commit into
cliffano wants to merge 1 commit into
Conversation
…ng or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/cliffano/jazz/security/code-scanning/2
General fix: when constructing a JavaScript string literal from raw text, escape backslashes first, then escape control characters and quotes globally.
Best minimal fix in
lib/jazz/compiler.jsis to update theast.Strhandling block in_compileExpr(lines 253–257 region) so it includes.replace(/\\/g, "\\\\")before the existing replacements. This preserves existing behavior while making escaping complete for backslashes.No new imports, helper methods, or dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.