ci: extract ansible and terraform setup into composite actions#331
Open
open-dave wants to merge 3 commits into
Open
ci: extract ansible and terraform setup into composite actions#331open-dave wants to merge 3 commits into
open-dave wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Replace the copy-pasted Python/pip/galaxy/vault/SSH and Tailscale/MinIO/ setup-terraform blocks across the workflows with the new composite actions. Drop the no-op ssh-agent eval, whose env never reached the playbook step. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Extend the ansible-setup composite action to ansible-adguard, ansible-claude, ansible-monitoring, and ansible-lint, which carried the same duplicated Python/pip/galaxy(/vault/SSH) boilerplate.
🏗️ Terraform Plan Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Extracts the copy-pasted setup sequences into two local composite actions and updates the workflows to call them:
.github/actions/ansible-setup—setup-python3.13,pip install -r requirements.txt, galaxy collection install, optional vault-password file, optional SSH key (inputs:vault-password,ssh-private-key, both optional so bootstrap/lint can reuse it with no secrets)..github/actions/terraform-setup— Tailscale connect, MinIO health check,hashicorp/setup-terraform(inputs:ts-oauth-client-id,ts-oauth-secret).Workflows refactored to single
uses:steps:ansible-base,ansible-update-proxmox,ansible-proxmox,ansible-proxmox-bootstrap,cluster-rebuild,terraform,terraform-plan, plusansible-adguard,ansible-claude,ansible-monitoring, andansible-lint.Why
Removes ~30 lines of duplicated Ansible setup and ~20 lines of Terraform setup per workflow, so version bumps (e.g. Python) are a single change.
Review findings addressed
ansible-adguard,ansible-claude,ansible-monitoring, andansible-lint, which were added after the issue was filed and carried the identical boilerplate — extended the composite to them so the duplication is fully removed.eval ssh-agentwas a no-op (its env never reached later steps; Ansible reads~/.ssh/id_ed25519directly).actionlint(validates local composite refs and inputs) and yamllint; no new lint violations.Closes #215
🤖 Generated with Claude Code