Conversation
Contributor
|
@tnavatar, @toneillbroad @theferrit32 is this old PR needed anymore? Should we close this or review and merge it? If anyone can assess, please do. If no one can assess, I think we should close it. |
Contributor
|
@larrybabb I believe this helm app isn't being run anymore but I'll let @tnavatar close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes genegraph's only secret, and defines the externalsecret manifest as an object managed by the helm chart (secrets were previously managed out of band).
I've also removed a secret variable (
SERVEUR_KEY_PASS) from the genegraph Deployment spec which didn't look like we were using.part of #322