feat: [ENG-2175] Re-enable OAPI validator #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radududu
commented
Jun 2, 2025
Comment on lines
101
to
107
| // In some instances, we want to continue processing the request | ||
| // even if validation fails. This is useful for logging or | ||
| // debugging purposes, or when the caller wants to handle the | ||
| // error in a different way. | ||
| if options == nil || !options.ContinueOnError { | ||
| return | ||
| } |
jonathan-chansin
approved these changes
Jun 9, 2025
pkg/chi-middleware/oapi_validate.go
Outdated
|
|
||
| // OapiRequestValidatorWithOptions Creates middleware to validate request by swagger spec. | ||
| // shouldWarnAboutServers checks if a warning about the `Servers` field in the OpenAPI spec should be logged. | ||
| func shouldWarnAboutServers(swagger *openapi3.T, options *Options) bool { |
There was a problem hiding this comment.
I understand why you did this, but I would keep the code as close as possible to the original code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
This is needed in https://github.com/clinia/atlas/pull/1683. The validator was disabled since 1.0.6. Latest is at 1.0.10.
Tests:
OAPI:
Atlas: