Polish PWA updates and Android mobile UX - #161
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
cloakpdf | 8f45734 | Commit Preview URL Branch Preview URL |
Jul 30 2026, 06:53 AM |
sumitsahoo
marked this pull request as ready for review
July 30, 2026 06:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The previous updater used a compact legacy toast that did not match current product surfaces and could appear visually ambiguous while applying an update. The launcher contract also relied on implicit icon-purpose behavior, while several coarse-pointer targets and programmatically focused headings rendered smaller or noisier than intended on narrow Android devices.
User impact
Installed CloakPDF users get a clearer, accessible update flow; Android launchers receive an explicit full-bleed maskable icon that stays inside every adaptive mask; and narrow-phone layouts retain clean alignment with 44px touch targets and an exact 50:50 editor sheet split.
Validation
vp checkpnpm check:deadpnpm test— 342 tests passedvp test run tests/unit/logo-assets.test.ts— 7 tests passedvp buildpnpm test:e2e:motiontests/e2e/home-routing.e2e.tstests/e2e/landing-search.e2e.tstests/e2e/modal-system.e2e.tspnpm generate-iconsreproduced the committed assets with no diffKnown test-harness mismatch:
editor-smoke-mobile.e2e.tscompletes the mobile sheet, crop, annotation, find/action, numbering, metadata, redact, and 12-panel render sweep, then waits for page 39 although the checked-in multipage fixture currently contains 33 pages.