Skip to content

Polish PWA updates and Android mobile UX - #161

Merged
sumitsahoo merged 3 commits into
mainfrom
dev
Jul 30, 2026
Merged

Polish PWA updates and Android mobile UX#161
sumitsahoo merged 3 commits into
mainfrom
dev

Conversation

@sumitsahoo

Copy link
Copy Markdown
Collaborator

Summary

  • redesign the PWA update and offline-ready notices to match CloakPDF’s instrument-style design system
  • add a guarded updating state so repeated taps cannot trigger duplicate service-worker updates
  • make ordinary and maskable manifest icon purposes explicit, size the Apple touch declaration, and add regression coverage for opacity, framing, dimensions, and Android maskable safe-zone geometry
  • improve narrow Android touch targets and remove misleading managed-focus outlines in the editor and portrait guidance overlay

Why

The previous updater used a compact legacy toast that did not match current product surfaces and could appear visually ambiguous while applying an update. The launcher contract also relied on implicit icon-purpose behavior, while several coarse-pointer targets and programmatically focused headings rendered smaller or noisier than intended on narrow Android devices.

User impact

Installed CloakPDF users get a clearer, accessible update flow; Android launchers receive an explicit full-bleed maskable icon that stays inside every adaptive mask; and narrow-phone layouts retain clean alignment with 44px touch targets and an exact 50:50 editor sheet split.

Validation

  • vp check
  • pnpm check:dead
  • pnpm test — 342 tests passed
  • vp test run tests/unit/logo-assets.test.ts — 7 tests passed
  • vp build
  • pnpm test:e2e:motion
  • tests/e2e/home-routing.e2e.ts
  • tests/e2e/landing-search.e2e.ts
  • tests/e2e/modal-system.e2e.ts
  • visual checks at 320, 375, 414, and 768px, plus 640×360 landscape
  • Android adaptive-icon previews under circle, squircle, rounded-square, and teardrop masks on light and dark wallpapers, including 48px launcher size
  • pnpm generate-icons reproduced the committed assets with no diff

Known test-harness mismatch: editor-smoke-mobile.e2e.ts completes the mobile sheet, crop, annotation, find/action, numbering, metadata, redact, and 12-panel render sweep, then waits for page 39 although the checked-in multipage fixture currently contains 33 pages.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 30, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
cloakpdf 8f45734 Commit Preview URL

Branch Preview URL
Jul 30 2026, 06:53 AM

@sumitsahoo
sumitsahoo marked this pull request as ready for review July 30, 2026 06:52
@sumitsahoo
sumitsahoo merged commit cd7f981 into main Jul 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant