[TS] Introduce v2 JS abi, with memory allocated by the caller#4186
Open
coolreader18 wants to merge 8 commits intomasterfrom
Open
[TS] Introduce v2 JS abi, with memory allocated by the caller#4186coolreader18 wants to merge 8 commits intomasterfrom
coolreader18 wants to merge 8 commits intomasterfrom
Conversation
c6485e0 to
3e53781
Compare
75a0bef to
3c331b1
Compare
3e53781 to
4c549ba
Compare
b4c1613 to
c5c8d0b
Compare
Centril
approved these changes
Feb 3, 2026
Contributor
There was a problem hiding this comment.
I've added a commit c5c8d0b to extract out common bits between v1 and v2.
Beyond that, I'd like to see documentation for:
- datastore_index_scan_point_bsatn
- datastore_delete_by_index_scan_point_bsatn
- with_arraybuffer_mut
- with_arraybuffer
- JsReturnValue
- procedure_start_mut_tx
- procedure_abort_mut_tx
- procedure_commit_mut_tx
Wherever it applies, I'd also like docs for v1 for the items above.
To the extent you prefer, you can also do this in a follow up.
c5c8d0b to
7cf7957
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The main difference from v1 is that syscalls that used to return
Uint8Arrays now instead acceptArrayBuffers and write into them. This greatly improves performance, since the module can now reuse buffers when calling into the host, instead of the host allocating anew on every call.To see the changes from v1 -> v2, you can check the diff between the head of this branch and the "Copy v1.rs to v2.rs" commit.
API and ABI breaking changes
Not sure whether this counts? A new ABI, but we're not breaking the old one.
Expected complexity level and risk
3 - mostly the same as the old one
Testing
No change in behavior, and the typescript package will use the new ABI even though its API isn't changing (yet).