[TS] Module-side performance improvements#4187
Open
coolreader18 wants to merge 4 commits intonoa/ts-guest-managed-memoryfrom
Open
[TS] Module-side performance improvements#4187coolreader18 wants to merge 4 commits intonoa/ts-guest-managed-memoryfrom
coolreader18 wants to merge 4 commits intonoa/ts-guest-managed-memoryfrom
Conversation
coolreader18
force-pushed
the
noa/ts-guest-managed-memory
branch
from
75a0bef to
3c331b1
Compare
coolreader18
force-pushed
the
noa/v8-perf-experiment
branch
from
1427e3e to
bf47449
Compare
coolreader18
force-pushed
the
noa/ts-guest-managed-memory
branch
from
c5c8d0b to
7cf7957
Compare
coolreader18
force-pushed
the
noa/v8-perf-experiment
branch
from
bf47449 to
4ec5244
Compare
| this.db = getDbView(); | ||
| } | ||
|
|
||
| static reset( |
Contributor
There was a problem hiding this comment.
Can we get a comment here?
| } | ||
| } | ||
|
|
||
| let REDUCER_CTX: InstanceType<typeof ReducerCtxImpl> | undefined; |
Contributor
There was a problem hiding this comment.
Can we get a comment here explaining this?
cloutiertyler
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Basically, cut down on creating new objects in the hot path as much as possible.
Expected complexity level and risk
1
Testing