Open
Conversation
…ext (#4101) # Description of Changes Makes the `sender` field on `ViewContext` private and exposes a `sender()` method. Does the same for `ReducerContext` and `ProcedureContext`. The purpose of this change: So that the host can determine if/when a view invokes or reads the `sender`. Currently, because `sender` is a field, the host assumes that it is always read. This means views must be materialized per client, even if the view doesn't actually depend on `sender`, resulting in data duplication. The initial solution for this problem was `AnonymousViewContext` which doesn't have a `sender` field. The better solution is to make `sender` a method so that it can call into the host and record when it's actually invoked. Note, this patch only updates the module API, so the current implementation does not change. `ViewContext` views are still duplicated across clients. Changing this requires a new host syscall and for `sender()` to invoke that syscall. This however is backwards compatible and can be done anytime after the module APIs for the other languages (C#, TypeScript, C++) are updated. Also note that `ReducerContext` and `ProcedureContext` were updated purely for consistency. There are currently no plans to track reads of `sender` in these contexts. # API and ABI breaking changes Breaks the rust module api. # Expected complexity level and risk 1 # Testing N/A
# Description of Changes Make `Sender` a method on [Reducer|View|Procedure|Tx]Context in C#. Equivalent changes to #4101. # API and ABI breaking changes API breaking # Expected complexity level and risk 1 # Testing Pure refactor, no additional testing.
# Description of Changes Switch Wasm module to `__describe_module_v10__` from `__describe_module__` to expose `RawModuleDefV10` # API and ABI breaking changes 2.0 breaking change. # Expected complexity level and risk 1 # Testing Exising smoketests should be enough.
Shubham8287
force-pushed
the
shub/raw-def-v8-new
branch
3 times, most recently
from
4c76c1c to
7526623
Compare
Shubham8287
force-pushed
the
shub/raw-def-v8-new
branch
from
7526623 to
21bcbf3
Compare
Shubham8287
force-pushed
the
shub/raw-def-v8-new
branch
from
21bcbf3 to
54701a9
Compare
Shubham8287
force-pushed
the
shub/raw-def-v8-new
branch
2 times, most recently
from
496e158 to
fcef782
Compare
# Description of Changes This particular line lost during rebasing of prev PRs. Now causing 2.0 branch to fail - #4115 # API and ABI breaking changes NA # Expected complexity level and risk 0
Shubham8287
force-pushed
the
shub/raw-def-v8-new
branch
from
4b3afed to
b10a31e
Compare
Shubham8287
force-pushed
the
2.0-breaking-changes
branch
from
a3b023c to
750ae7d
Compare
Shubham8287
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
V8 Modules to expose
RawModuleDefV10API and ABI breaking changes
It breaks client, hence should be merged in
2.0-breaking-changesTesting