Disabled codegen for private tables by default#4197
Open
JasonAtClockwork wants to merge 8 commits into2.0-breaking-changesfrom
Open
Disabled codegen for private tables by default#4197JasonAtClockwork wants to merge 8 commits into2.0-breaking-changesfrom
JasonAtClockwork wants to merge 8 commits into2.0-breaking-changesfrom
Conversation
…roke and I'm not certain why yet
…d fixed up the Unreal tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Updated the codegen table iteration functions to take in a parameter to include private and defaulted it false in all locations for the supported languages.
API and ABI breaking changes
Technically API breaking as the private tables will no longer be available. (GitHub labels are not working at the moment)
Expected complexity level and risk
1 - Simple change the testing took longer
Testing
Turns out when you remove private tables you invalidate most of the module_bindings across the system!