Open
Conversation
Member
Author
|
Yeah, this idiot forgot that tools.reader also comes as a transitive dependency of cljfmt. Can't get rid of that one. |
alexander-yakushev
changed the title
alexander-yakushev
force-pushed
the
no-more-reader
branch
2 times, most recently
from
7f5312e to
68295ce
Compare
alexander-yakushev
force-pushed
the
no-more-reader
branch
from
68295ce to
551ca06
Compare
Member
Author
|
Update: even if we can't drop tools.reader yet, it makes sense to stop depending on its functions directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks to me like we don't use
tools.readerenough to justify keeping it as a dependency. Regular Clojure'sreadandclojure.ednshould be sufficient.