Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the project, focusing on enhancing Eclipse IDE compatibility through new settings files and significantly expanding the test coverage for the
ReusablePoolclass. The most important changes are grouped below:Eclipse IDE Integration:
.settings/org.eclipse.core.resources.prefs,.settings/org.eclipse.jdt.core.prefs, and.settings/org.eclipse.m2e.core.prefsto configure Eclipse workspace, Java compiler, and Maven integration, ensuring consistent project setup and encoding across development environments. [1] [2] [3]Testing Enhancements:
ReusablePoolTest.javato include comprehensive unit tests for singleton behavior, successful acquisition and release of resources, and proper exception handling for edge cases, improving code reliability and maintainability.CI/CD Workflow Update:
.github/workflows/Java17CImaven.ymlto explicitly grant write permissions to workflow contents, which may be required for publishing artifacts or updating repository content during CI runs.