Skip to content

fix: replace deprecated aws_region .name attribute with .id#107

Open
babyhuey wants to merge 1 commit into
cloudandthings:mainfrom
babyhuey:fix/deprecated-aws-region-name
Open

fix: replace deprecated aws_region .name attribute with .id#107
babyhuey wants to merge 1 commit into
cloudandthings:mainfrom
babyhuey:fix/deprecated-aws-region-name

Conversation

@babyhuey

@babyhuey babyhuey commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace deprecated data.aws_region.current.name with data.aws_region.current.id in the SSM parameter ARN construction
  • The name attribute on the aws_region data source has been deprecated in recent AWS provider versions; id returns the same value

Test plan

  • terraform validate passes with no warnings from this module's code

@babyhuey
babyhuey force-pushed the fix/deprecated-aws-region-name branch from 35afd91 to ba6e912 Compare April 9, 2026 19:59
@babyhuey

babyhuey commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

Rebased on latest main and verified all checks locally in a Python 3.11.2 Docker container:

  • black 22.6.0: passing
  • flake8 5.0.4: passing
  • terraform validate: passing (only warning is from the upstream lambda module)
  • All deployment zips up to date
  • All 12 unit tests passing

@baolsen baolsen self-assigned this Jun 5, 2026
@baolsen

baolsen commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Thank you also for this one @babyhuey

I see it's conflicted at the moment. Let's get #113 merged first, it bumps the AWS provider to v6 so then we could relook at this one.

We will get there eventually :)

The `name` attribute on the `aws_region` data source is deprecated
in recent AWS provider versions. Use `id` instead, which returns
the same value.
@babyhuey
babyhuey force-pushed the fix/deprecated-aws-region-name branch from ba6e912 to d61820b Compare June 12, 2026 17:56
@babyhuey

Copy link
Copy Markdown
Contributor Author

Hey @baolsen, just rebased this on top of the latest main (which includes #113 and the other recent merges) and all checks are passing. Ready for review whenever you get a chance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants