Skip to content

Release scripts now run with a supported version and add the proper t… #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitch292 merged 1 commit into from
Feb 24, 2026
Merged

Release scripts now run with a supported version and add the proper t… #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/manual-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: '1.23'
go-version: '1.21'
Copy link
Contributor Author

@mitch292 mitch292 Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prevents the below changes in the cert metadata files

	Signature algorithm: RSA / MD2
	Signature algorithm: unknown public key algorithm / unknown hash algorithm

- run: go version
- name: Install dependencies
run: |
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
with:
source_branch: "release/${{ env.LATEST_RELEASE }}"
destination_branch: "master"
pr_reviewer: "lgarofalo,cloudflare/ssl-tls-team"
pr_reviewer: "cloudflare/ssltls"
Copy link
Contributor Author

@mitch292 mitch292 Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our team name changed recently, the team includes Leland's user

pr_assignee: "lgarofalo"
github_token: ${{ secrets.GITHUB_TOKEN }}
- name: Google Chat Notification
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/scheduled-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: '1.23'
go-version: '1.21'
- run: go version
- name: Install dependencies
run: |
Expand All @@ -38,7 +38,7 @@ jobs:
with:
source_branch: "release/${{ env.LATEST_RELEASE }}"
destination_branch: "master"
pr_reviewer: "lgarofalo,cloudflare/ssl-tls-team"
pr_reviewer: "cloudflare/ssltls"
pr_assignee: "lgarofalo"
github_token: ${{ secrets.GITHUB_TOKEN }}
- name: Google Chat Notification
Expand Down
10 changes: 7 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Dockerfile for cfssl_trust release environment
# Provides Go 1.24, certdump, cfssl tools, and cfssl-trust
# Dockerfile to run the cfssl_trust release script locally.
# WARP must be turned off to run the script.
# Provides Go 1.21, certdump, cfssl tools, and cfssl-trust

FROM golang:1.24-bookworm
FROM golang:1.21-bookworm

# Install git and update CA certificates
RUN apt-get update && apt-get install -y \
Expand All @@ -19,6 +20,9 @@ RUN go install git.wntrmute.dev/kyle/goutils/cmd/certdump@v1.7.7
# Install cfssl tools
RUN go install github.com/cloudflare/cfssl/cmd/...

# Install cfssl tools
RUN go install github.com/cloudflare/cfssl_trust/...

# Set working directory
WORKDIR /cfssl_trust

Expand Down