Skip to content

fix(forms): reset group fieldset padding - #801

Merged
mattrothenberg merged 2 commits into
mainfrom
fix/reset-group-fieldset-padding
Sep 14, 2026
Merged

mattrothenberg merged 2 commits into
mainfrom
fix/reset-group-fieldset-padding

Conversation

@mattrothenberg

Copy link
Copy Markdown
Collaborator

Summary

  • reset native fieldset padding in Radio.Group and Checkbox.Group so host styles cannot add unwanted group spacing
  • add focused regression coverage for both group components

Validation

  • pnpm --filter @cloudflare/kumo test --run src/components/radio/radio.test.tsx src/components/checkbox/checkbox.test.tsx

  • pnpm --filter @cloudflare/kumo lint

  • pnpm --filter @cloudflare/kumo exec vp fmt --check src/components/radio/radio.tsx src/components/radio/radio.test.tsx src/components/checkbox/checkbox.tsx src/components/checkbox/checkbox.test.tsx

  • git diff --check

  • Reviews

  • bonk has reviewed the change

  • automated review not possible because: this environment cannot request a Bonk review.

  • Tests

  • Tests included/updated

  • Automated tests not possible - manual testing has been completed as follows: not applicable

  • Additional testing not necessary because: not applicable

@ask-bonk

ask-bonk Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

LGTM!

Review notes
  • Confirming PR #801 and inspecting its diff, existing reviews, and the Kumo package review conventions.
  • PR metadata confirms #801; the checked-out repository lacks origin/main, so I will compare the authoritative trigger commit directly through GitHub and run the targeted component tests locally if dependencies permit. The current PR has no submitted reviews.
  • The authoritative commit a2b0daf changes only the two group fieldsets, adds a patch changeset, and adds/updates their tests; there are no existing inline review comments to avoid duplicating.
  • The targeted test command could not run because pnpm is not installed in this runner. I am checking class-merging and stylesheet generation paths to verify the important padding reset reaches the rendered fieldsets.
  • Diff validation for a2b0daf passes with no whitespace errors. The !p-0 utilities are present on both rendered Fieldset.Root elements and are included in the standalone Tailwind stylesheet input; no behavior, accessibility, or API regression was identified.
  • GitHub reports no required checks for the branch. The PR’s only post-trigger commit is a merge from main; the reviewed change remains the authoritative a2b0daf patch.

github run

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 14, 2026

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://fix-reset-group-fieldset-padding-kumo-docs.design-engineering.workers.dev (commit d0875a3)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://0ac24b4e-kumo-docs.design-engineering.workers.dev d0875a3 2026-09-14T14:11:15.331Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://44df8abc-kumo-docs.design-engineering.workers.dev c892923 2026-09-14T13:50:43.095Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://12755bee-kumo-docs.design-engineering.workers.dev 452ff36 2026-09-14T13:30:46.628Z Visit the dashboard ↗

@pkg-pr-new

pkg-pr-new Bot commented Sep 14, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/kumo@801

commit: d0875a3

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor
Visual Regression Report — 19 changed, 6 unchanged

19 screenshot(s) with visual changes:

Checkbox / Checkbox Basic

678 px (0.77%) changed

Before After Diff
Before After Diff

Checkbox / Checkbox Default

307 px (0.35%) changed

Before After Diff
Before After Diff

Checkbox / Checkbox Checked

264 px (0.3%) changed

Before After Diff
Before After Diff

Checkbox / Checkbox Indeterminate

334 px (0.38%) changed

Before After Diff
Before After Diff

Checkbox / Checkbox Label First

335 px (0.38%) changed

Before After Diff
Before After Diff

Checkbox / Checkbox Disabled

412 px (0.47%) changed

Before After Diff
Before After Diff

Checkbox / Checkbox Error

334 px (0.38%) changed

Before After Diff
Before After Diff

Checkbox / Checkbox Group Error

1,806 px (1.46%) changed

Before After Diff
Before After Diff

Checkbox / Checkbox Legend Sr Only

801 px (0.84%) changed

Before After Diff
Before After Diff

Checkbox / Checkbox Legend Custom

1,110 px (0.99%) changed

Before After Diff
Before After Diff

Radio / Radio Description

2,509 px (1.73%) changed

Before After Diff
Before After Diff

Radio / Radio Card

5,034 px (1.8%) changed

Before After Diff
Before After Diff

Radio / Radio Card Control Start

3,282 px (1.96%) changed

Before After Diff
Before After Diff

Radio / Radio Rich Label

2,036 px (1.22%) changed

Before After Diff
Before After Diff

Radio / Radio Card Horizontal

6,610 px (3.47%) changed

Before After Diff
Before After Diff

Radio / Radio Error

1,917 px (0.95%) changed

Before After Diff
Before After Diff

Radio / Radio Disabled

5,909 px (2.36%) changed

Before After Diff
Before After Diff

Radio / Radio Legend Sr Only

632 px (0.71%) changed

Before After Diff
Before After Diff

Radio / Radio Legend Custom

1,031 px (0.92%) changed

Before After Diff
Before After Diff
6 screenshot(s) unchanged
  • Checkbox / Checkbox Group
  • Radio / Radio Basic
  • Radio / Radio Default
  • Radio / Radio Horizontal
  • Radio / Radio Control Position
  • Radio / Radio Typed Value

Generated by Kumo Visual Regression

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

📐 Bundle Size

Consumer fixtures bundled against packages/kumo/dist (peers external, minified ESM).

Fixture Raw Gzip Brotli
Button (root) 174.6 KB 49.9 KB 43.1 KB
Button (components/button) 174.5 KB 49.9 KB 43.0 KB
Button + Dialog + Select (root) 299.5 KB 85.8 KB 71.8 KB
Button + Dialog + Select (component subpaths) 299.5 KB 85.9 KB 71.8 KB
Chart (root) 218.7 KB 63.4 KB 54.7 KB
Chart (components/chart) 218.6 KB 63.3 KB 54.7 KB
Badge (components/badge) 44.7 KB 11.7 KB 10.0 KB
Flow (components/flow) 208.9 KB 58.3 KB 50.5 KB
Button (primitives/button) 12.2 KB 4.4 KB 3.9 KB
Primitives barrel 635.8 KB 176.9 KB 139.3 KB
Code highlighting (code) 2.08 MB 467.9 KB 349.2 KB

npm tarball: 535 files, 1.47 MB packed, 6.84 MB unpacked.

⚠️ 22 flagged files in tarball (tests / raw scripts)
  • dist/blocks-source/resource-list/resource-list.test.tsx
  • scripts/component-registry/cache.ts
  • scripts/component-registry/discovery.ts
  • scripts/component-registry/example-cleanup.ts
  • scripts/component-registry/index.test.ts
  • scripts/component-registry/index.ts
  • scripts/component-registry/markdown-generator.ts
  • scripts/component-registry/metadata.ts
  • scripts/component-registry/props-filter.ts
  • scripts/component-registry/schema-generator.ts
  • scripts/component-registry/sub-components.ts
  • scripts/component-registry/types.ts
  • scripts/component-registry/utils.ts
  • scripts/component-registry/variant-parser.ts
  • scripts/css-build.ts
  • scripts/generate-primitives.ts
  • scripts/theme-generator/config.ts
  • scripts/theme-generator/generate-css.test.ts
  • scripts/theme-generator/generate-css.ts
  • scripts/theme-generator/index.ts
  • scripts/theme-generator/migrate.ts
  • scripts/theme-generator/types.ts

Report-only: no size thresholds are enforced yet.

Commit: d0875a3a

@mattrothenberg
mattrothenberg force-pushed the fix/reset-group-fieldset-padding branch from 452ff36 to c892923 Compare September 14, 2026 13:47
@mattrothenberg mattrothenberg self-assigned this Sep 14, 2026
@mattrothenberg
mattrothenberg merged commit de80043 into main Sep 14, 2026
18 checks passed
@mattrothenberg
mattrothenberg deleted the fix/reset-group-fieldset-padding branch September 14, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants