Skip to content

feat(code): add plain variant to CodeHighlighted component - #802

Open
invisal wants to merge 6 commits into
cloudflare:mainfrom
invisal:feat/frameless-code-block
Open

invisal wants to merge 6 commits into
cloudflare:mainfrom
invisal:feat/frameless-code-block

Conversation

@invisal

@invisal invisal commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

This PR introduces a plain variant to the CodeHighlighted component, allowing frameless code blocks

Reviews

  • bonk has reviewed the change
  • automated review not possible because:

Tests

  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because:

@pkg-pr-new

pkg-pr-new Bot commented Sep 14, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/kumo@802

commit: 1e81b15

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Docs Preview

View docs preview

Commit: 1e81b15

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

📐 Bundle Size

Consumer fixtures bundled against packages/kumo/dist (peers external, minified ESM).

Fixture Raw Gzip Brotli
Button (root) 174.6 KB 49.9 KB 43.1 KB
Button (components/button) 174.5 KB 49.9 KB 43.0 KB
Button + Dialog + Select (root) 299.5 KB 85.8 KB 71.8 KB
Button + Dialog + Select (component subpaths) 299.5 KB 85.9 KB 71.8 KB
Chart (root) 218.7 KB 63.4 KB 54.7 KB
Chart (components/chart) 218.6 KB 63.3 KB 54.7 KB
Badge (components/badge) 44.7 KB 11.7 KB 10.0 KB
Flow (components/flow) 208.9 KB 58.3 KB 50.5 KB
Button (primitives/button) 12.2 KB 4.4 KB 3.9 KB
Primitives barrel 635.8 KB 176.9 KB 139.3 KB
Code highlighting (code) 2.08 MB 468.0 KB 349.2 KB

npm tarball: 535 files, 1.47 MB packed, 6.84 MB unpacked.

⚠️ 22 flagged files in tarball (tests / raw scripts)
  • dist/blocks-source/resource-list/resource-list.test.tsx
  • scripts/component-registry/cache.ts
  • scripts/component-registry/discovery.ts
  • scripts/component-registry/example-cleanup.ts
  • scripts/component-registry/index.test.ts
  • scripts/component-registry/index.ts
  • scripts/component-registry/markdown-generator.ts
  • scripts/component-registry/metadata.ts
  • scripts/component-registry/props-filter.ts
  • scripts/component-registry/schema-generator.ts
  • scripts/component-registry/sub-components.ts
  • scripts/component-registry/types.ts
  • scripts/component-registry/utils.ts
  • scripts/component-registry/variant-parser.ts
  • scripts/css-build.ts
  • scripts/generate-primitives.ts
  • scripts/theme-generator/config.ts
  • scripts/theme-generator/generate-css.test.ts
  • scripts/theme-generator/generate-css.ts
  • scripts/theme-generator/index.ts
  • scripts/theme-generator/migrate.ts
  • scripts/theme-generator/types.ts

Report-only: no size thresholds are enforced yet.

Commit: d8885498

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor
Visual Regression Report — 32 changed, 13 unchanged

32 screenshot(s) with visual changes:

Button / Basic

342 px (0.39%) changed

Before After Diff
Before After Diff

Button / Variant: Secondary

411 px (0.46%) changed

Before After Diff
Before After Diff

Button / Sizes

1,089 px (1.23%) changed

Before After Diff
Before After Diff

Button / Icon Only

188 px (0.21%) changed

Before After Diff
Before After Diff

Button / Loading State

25 px (0.03%) changed

Before After Diff
Before After Diff

Button / Disabled State

117 px (0.13%) changed

Before After Diff
Before After Diff

Button / Link with Tooltip

579 px (0.65%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Actions

361 px (0.41%) changed

Before After Diff
Before After Diff

Dialog / Dialog Basic

404 px (0.46%) changed

Before After Diff
Before After Diff

Dialog / Dialog Sizes

3,041 px (3.43%) changed

Before After Diff
Before After Diff

Dialog / Dialog Confirmation

855 px (0.97%) changed

Before After Diff
Before After Diff

Dialog / Custom Max Width

1,013 px (1.14%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Combobox

497 px (0.56%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Dropdown

386 px (0.44%) changed

Before After Diff
Before After Diff

Dialog (Open)

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Sizes

2,670 px (1.64%) changed

Before After Diff
Before After Diff

Select / Select Placement

4,273 px (2.95%) changed

Before After Diff
Before After Diff

Select / Select Dynamic Placement

3,376 px (3.24%) changed

Before After Diff
Before After Diff

Select / Select Without Label

573 px (0.65%) changed

Before After Diff
Before After Diff

Select / Select With Error

1,730 px (1.66%) changed

Before After Diff
Before After Diff

Select / Select Placeholder

977 px (1.1%) changed

Before After Diff
Before After Diff

Select / Select With Tooltip

196 px (0.22%) changed

Before After Diff
Before After Diff

Select / Select Custom Rendering

973 px (1.1%) changed

Before After Diff
Before After Diff

Select / Select Loading

2,375 px (1.35%) changed

Before After Diff
Before After Diff

Select / Select Multiple

1,550 px (1.75%) changed

Before After Diff
Before After Diff

Select / Select Complex

181 px (0.17%) changed

Before After Diff
Before After Diff

Select / Select Disabled Options

1,541 px (1.74%) changed

Before After Diff
Before After Diff

Select / Select Disabled Items

793 px (0.9%) changed

Before After Diff
Before After Diff

Select / Select Grouped

813 px (0.92%) changed

Before After Diff
Before After Diff

Select / Select Grouped With Disabled

190 px (0.21%) changed

Before After Diff
Before After Diff

Select / Select Long List

1,354 px (1.3%) changed

Before After Diff
Before After Diff

Select (Open)

1,263 px (0%) changed

Before After Diff
Before After Diff
13 screenshot(s) unchanged
  • Button / Variant: Primary
  • Button / Variant: Ghost
  • Button / Variant: Destructive
  • Button / Variant: Outline
  • Button / Variant: Secondary Destructive
  • Button / With Icon
  • Button / Title
  • Button / Link as Button
  • Button / Disabled Link
  • Dialog / Dialog Alert
  • Dialog / Dialog With Select
  • Select / Select Basic
  • Select / Select With Description

Generated by Kumo Visual Regression

@github-actions

Copy link
Copy Markdown
Contributor

Visual contracts

Linux Chromium references exercised by the PR's visual-contracts job.

1 curated contract

truncating text trigger

truncating text trigger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants