Skip to content

feat(inline-copy-text): add compact copy control - #805

Merged
mattrothenberg merged 2 commits into
mainfrom
nanda/DESENG-1685-inline-copy-text
Sep 16, 2026
Merged

mattrothenberg merged 2 commits into
mainfrom
nanda/DESENG-1685-inline-copy-text

Conversation

@nandanmen

@nandanmen nandanmen commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Supports DESENG-1685.

Summary

  • add InlineCopyText, a compact borderless copy control for IDs and other short inline values
  • support localized copy feedback, alternate copied text, native button props, and ref forwarding
  • expose barrel and granular package exports and register the component with Kumo tooling
  • add component documentation, demos, unit coverage, and a minor changeset
CleanShot 2026-09-15 at 11 42 03@2x

Testing

  • pnpm --filter @cloudflare/kumo test:unit
  • pnpm --filter @cloudflare/kumo test:exports
  • pnpm --filter @cloudflare/kumo lint
  • pnpm --filter @cloudflare/kumo typecheck
  • pnpm --filter @cloudflare/kumo build
  • pnpm --filter @cloudflare/kumo-docs-astro lint
  • pnpm --filter @cloudflare/kumo-docs-astro typecheck
  • pnpm --filter @cloudflare/kumo-docs-astro build
  • pnpm format:check
  • git diff --check

The visual-contract command also ran, but the existing tooltip contract differed from its stored macOS screenshot dimensions (expected 148×38px, received 194×50px). No InlineCopyText visual contract failed.


  • Reviews
    • bonk has reviewed the change
    • automated review not possible because: Bonk cannot review the change until this PR exists
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:

@pkg-pr-new

pkg-pr-new Bot commented Sep 15, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/kumo@805

commit: 9615846

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Visual contracts

Linux Chromium references exercised by the PR's visual-contracts job.

1 curated contract

truncating text trigger

truncating text trigger

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

📐 Bundle Size

Consumer fixtures bundled against packages/kumo/dist (peers external, minified ESM).

Fixture Raw Gzip Brotli
Button (root) 174.6 KB 49.9 KB 43.1 KB
Button (components/button) 174.5 KB 49.9 KB 43.1 KB
Button + Dialog + Select (root) 299.5 KB 85.8 KB 71.9 KB
Button + Dialog + Select (component subpaths) 299.5 KB 85.9 KB 71.9 KB
Chart (root) 247.0 KB 71.1 KB 60.9 KB
Chart (components/chart) 246.9 KB 71.1 KB 60.9 KB
Badge (components/badge) 44.7 KB 11.7 KB 10.0 KB
Flow (components/flow) 208.9 KB 58.3 KB 50.5 KB
Button (primitives/button) 12.2 KB 4.4 KB 3.9 KB
Primitives barrel 635.8 KB 176.9 KB 139.3 KB
Code highlighting (code) 2.08 MB 467.9 KB 349.1 KB

npm tarball: 544 files, 1.49 MB packed, 6.94 MB unpacked.

⚠️ 23 flagged files in tarball (tests / raw scripts)
  • dist/blocks-source/resource-list/resource-list.test.tsx
  • scripts/component-registry/cache.ts
  • scripts/component-registry/discovery.ts
  • scripts/component-registry/example-cleanup.ts
  • scripts/component-registry/index.test.ts
  • scripts/component-registry/index.ts
  • scripts/component-registry/markdown-generator.ts
  • scripts/component-registry/metadata.ts
  • scripts/component-registry/props-filter.ts
  • scripts/component-registry/schema-generator.ts
  • scripts/component-registry/sub-components.ts
  • scripts/component-registry/types.ts
  • scripts/component-registry/utils.ts
  • scripts/component-registry/variant-parser.ts
  • scripts/css-build.ts
  • scripts/generate-globe-land-mask.mjs
  • scripts/generate-primitives.ts
  • scripts/theme-generator/config.ts
  • scripts/theme-generator/generate-css.test.ts
  • scripts/theme-generator/generate-css.ts
  • scripts/theme-generator/index.ts
  • scripts/theme-generator/migrate.ts
  • scripts/theme-generator/types.ts

Report-only: no size thresholds are enforced yet.

Commit: 96158468

@github-actions

Copy link
Copy Markdown
Contributor
Visual Regression Report — 28 changed, 17 unchanged

28 screenshot(s) with visual changes:

Button / Icon Only

187 px (0.21%) changed

Before After Diff
Before After Diff

Button / Loading State

6 px (0.01%) changed

Before After Diff
Before After Diff

Button / Disabled State

0 px (0%) changed

Before After Diff
Before After Diff

Button / Title

405 px (0.46%) changed

Before After Diff
Before After Diff

Button / Link as Button

1,134 px (1.28%) changed

Before After Diff
Before After Diff

Button / Link with Tooltip

245 px (0.28%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Actions

362 px (0.41%) changed

Before After Diff
Before After Diff

Dialog / Dialog Sizes

2,864 px (3.23%) changed

Before After Diff
Before After Diff

Dialog / Dialog Alert

1,321 px (1.49%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Select

547 px (0.62%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Combobox

480 px (0.54%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Dropdown

383 px (0.43%) changed

Before After Diff
Before After Diff

Dialog (Open)

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Basic

1,048 px (1.18%) changed

Before After Diff
Before After Diff

Select / Select Sizes

2,500 px (1.54%) changed

Before After Diff
Before After Diff

Select / Select Placement

332 px (0.23%) changed

Before After Diff
Before After Diff

Select / Select Dynamic Placement

188 px (0.18%) changed

Before After Diff
Before After Diff

Select / Select Without Label

723 px (0.82%) changed

Before After Diff
Before After Diff

Select / Select Placeholder

978 px (1.1%) changed

Before After Diff
Before After Diff

Select / Select Custom Rendering

1,153 px (1.3%) changed

Before After Diff
Before After Diff

Select / Select Loading

3,005 px (1.7%) changed

Before After Diff
Before After Diff

Select / Select Multiple

938 px (1.06%) changed

Before After Diff
Before After Diff

Select / Select Complex

1,392 px (1.34%) changed

Before After Diff
Before After Diff

Select / Select Disabled Items

785 px (0.89%) changed

Before After Diff
Before After Diff

Select / Select Grouped

937 px (1.06%) changed

Before After Diff
Before After Diff

Select / Select Grouped With Disabled

1,455 px (1.64%) changed

Before After Diff
Before After Diff

Select / Select Long List

2,196 px (2.11%) changed

Before After Diff
Before After Diff

Select (Open)

0 px (0%) changed

Before After Diff
Before After Diff
17 screenshot(s) unchanged
  • Button / Basic
  • Button / Variant: Primary
  • Button / Variant: Secondary
  • Button / Variant: Ghost
  • Button / Variant: Destructive
  • Button / Variant: Outline
  • Button / Variant: Secondary Destructive
  • Button / Sizes
  • Button / With Icon
  • Button / Disabled Link
  • Dialog / Dialog Basic
  • Dialog / Dialog Confirmation
  • Dialog / Custom Max Width
  • Select / Select With Description
  • Select / Select With Error
  • Select / Select With Tooltip
  • Select / Select Disabled Options

Generated by Kumo Visual Regression

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 15, 2026

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://nanda-deseng-1685-inline-copy-text-kumo-docs.design-engineering.workers.dev (commit 9615846)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://0f1efb8f-kumo-docs.design-engineering.workers.dev 9615846 2026-09-16T17:58:27.547Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://bd833614-kumo-docs.design-engineering.workers.dev 47ecea7 2026-09-15T18:34:39.609Z Visit the dashboard ↗

@ask-bonk

ask-bonk Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@nandanmen Bonk workflow was cancelled.

View workflow run · To retry, trigger Bonk again.

@mattrothenberg
mattrothenberg merged commit 5d19dee into main Sep 16, 2026
19 checks passed
@mattrothenberg
mattrothenberg deleted the nanda/DESENG-1685-inline-copy-text branch September 16, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants