Conversation
kornelski
requested review from
a team,
Noah-Kennedy,
jasnell and
orium
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E::MatchPayloadwasSelectorHandlersLocator, which was getting copied all over the selector matching vm, and infected everything with a generic type.Matches were stored in
HashSet<SelectorHandlersLocator>, but theHashSetcouldn't be iterated, because that wouldn't have a deterministic order. The solution for that was calling handlers eagerly, and passingmatch_handler: &mut dyn FnMut(MatchInfo<E::MatchPayload>), adding more args and generics.I've made
SelectorHandlersLocator3x smaller, and realized it doesn't even have to exist in the selector vm. Instead of replacingHashSet<SelectorHandlersLocator>withHashSet<usize>, I've made a basic bitset for it, which in common case (< 184 handlers) doesn't use heap allocations and has super fast union.The bitset can be iterated in a deterministic order, so I could also remove a bunch of
match_handler: &mut dyn FnMut(MatchInfo<E::MatchPayload>)early calls, and call all handlers once in a loop, which simplifies things a lot (movingmatch_handlerout of the bailout/resume machinery). ManyDefaultHasherBuilders are gone too.