fix: Replace single-slot datagram buffer with FIFO queue to prevent p…#133
Open
Cyberalle wants to merge 2 commits intocloudflare:mainfrom
Open
fix: Replace single-slot datagram buffer with FIFO queue to prevent p…#133Cyberalle wants to merge 2 commits intocloudflare:mainfrom
Cyberalle wants to merge 2 commits intocloudflare:mainfrom
Conversation
…acket loss The original implementation used a "last-write-wins" pattern that stored only the most recent datagram, causing approximately 75% packet loss in relay scenarios with multiple subscribers. This change: - Replaces `latest: Option<Datagram>` with `queue: VecDeque<Datagram>` - Adds configurable buffer size (MAX_DATAGRAM_BUFFER = 1024) - Implements proper multi-reader support using absolute position tracking - Each reader maintains `consumed_count` to track its position independently - Buffer overflow drops oldest datagrams while preserving reader positions This enables proper QUIC datagram relay for real-time media applications where packet throughput is critical.
- Add debug logging for SUBSCRIBE_OK handling to trace track_alias mapping - Fix potential deadlock by releasing subscribes lock before acquiring alias_map lock - Log alias_map state for troubleshooting datagram routing issues - Convert extension header logging from info to debug level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…acket loss
The original implementation used a "last-write-wins" pattern that stored only the most recent datagram, causing approximately 75% packet loss in relay scenarios with multiple subscribers.
This change:
latest: Option<Datagram>withqueue: VecDeque<Datagram>consumed_countto track its position independentlyThis enables proper QUIC datagram relay for real-time media applications where packet throughput is critical.