Open
Conversation
To do this while adhering to the draft as much as possible, the following changes had to be made: * Add filter type parameter for subscribe calls * Fix filter type checks in Subscribe encoding * Remove SubscribeLocation according to draft-04 * Update Subscribe according to draft-08 (end -> end_group) * Update FilterType according to draft-09 (remove LatestGroup)
* Change fields of SubscribeDone * Introduce stream_count to `SubscribedState` * Remove dependency on msg format from `Subscribed`
When a `Subscribe` or a `SubscribeUpdate` is received with a non-empty list of Subscribe Parameters, a warning is logged to note the use of the unimplemented feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have made some changes primarily related to the implementation of the
SubscribeUpdatemessage.While I was working on this, I kept finding new issues and inconsistencies between the draft and the code base. Some of which were closely related, and some of which had a bit more loose connection with the main objective. I decided to include them all in order to have a more complete changeset.
Related PRs and Issues
Supersedes:
Fixes: