fix: gracefully handle PMTU probe errors.#2366
Merged
Conversation
LPardue
reviewed
Feb 23, 2026
Contributor
|
I'd like @cf-rhett to take a look at this PR too |
cf-rhett
reviewed
Feb 24, 2026
toidiu
force-pushed
the
akothari/pmtu_error_handling
branch
from
751eb11 to
d4846b2
Compare
Contributor
|
Everything looks good to me. I don't have official approval power but Approved from my side |
LPardue
approved these changes
Feb 25, 2026
toidiu
force-pushed
the
akothari/pmtu_error_handling
branch
from
d4846b2 to
382f1d5
Compare
toidiu
force-pushed
the
akothari/pmtu_error_handling
branch
from
382f1d5 to
4323eb3
Compare
schien
approved these changes
Feb 25, 2026
PMTU probes are not critical for QUIC functionality so it is better to handle errors from this module more gracefully.
toidiu
force-pushed
the
akothari/pmtu_error_handling
branch
from
4323eb3 to
a52d928
Compare
Contributor
protip: you can disable whitespace changes in the diff settings: |
jrouviere
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMTU probes are not critical for QUIC functionality so it is better to handle errors from this module more gracefully.
The diff is large due to the tab shift but the only important change is:
let active_path = self.paths.get_active_mut()?;to
if let Ok(active_path) = self.paths.get_active_mut()