[perf][o11y] Avoid another event-level memory allocation when internal tracing is not being used #5586
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mar-cf
reviewed
Dec 10, 2025
Contributor
mar-cf
left a comment
mar-cf
left a comment
There was a problem hiding this comment.
"no tracing" should explicitly represented as kj::none rather than a fake object that silently does nothing. Is there a reason not to do that?
fhanau
force-pushed
the
felix/112525-o11y-perf
branch
from
f3f22ec to
eb812f9
Compare
|
The generated output of |
…l tracing is not being used
fhanau
force-pushed
the
felix/112525-o11y-perf
branch
from
eb812f9 to
8802ce1
Compare
Contributor
Author
Discussed out-of-band – for now this PR gets rid of one allocation, I created issue EW-9829 to explore not setting up a trace scope at all at a future time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.