First attempt at tags for V8 external fields. #5656
Draft
+56
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #5656 will not alter performanceComparing Summary
Footnotes
|
jasnell
reviewed
Dec 8, 2025
erikcorry
force-pushed
the
erikcorry/external-type-tags
branch
from
adccd5d to
704634d
Compare
jasnell
approved these changes
Dec 9, 2025
anonrig
reviewed
Dec 10, 2025
|
|
||
| // V8 14.3+ supports external pointer type tags for security. | ||
| #define V8_HAS_EXTERNAL_POINTER_TAGS \ | ||
| (V8_MAJOR_VERSION > 14 || (V8_MAJOR_VERSION == 14 && V8_MINOR_VERSION >= 3)) |
Member
There was a problem hiding this comment.
Since main branch is on v8 14.3 I don't think we need this compile time flag
Comment on lines
+16
to
+17
| kCapnpSchema = 1, | ||
| kCapnpInterfaceMethod = 2, |
Member
There was a problem hiding this comment.
Would you mind expanding the comments and add a one liner for each id here.
Comment on lines
+391
to
+392
| [[maybe_unused]] constexpr auto tag = | ||
| static_cast<uint16_t>(jsg::JsgExternalIds::kCapnpInterfaceMethod); |
Member
There was a problem hiding this comment.
Can't we just move this to inside the compile time flag?
| @@ -1,5 +1,6 @@ | |||
| #pragma once | |||
|
|
|||
| #include "external-tags.h" | |||
Member
There was a problem hiding this comment.
We don't need this here, we don't use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.