Skip to content

worker-build: retry binary downloads on failure - #1065

Merged
guybedford merged 1 commit into
cloudflare:mainfrom
op:op/wasm-opt-retries
Sep 15, 2026
Merged

guybedford merged 1 commit into
cloudflare:mainfrom
op:op/wasm-opt-retries

Conversation

@op

@op op commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Downloads of tool binaries would fail the entire build on any transient network error. Retry the download up to 5 attempts with exponential backoff (2s, 4s, 8s, 16s), warning between attempts. Also truncate extracted files on write so a retry after a partial extraction cannot leave trailing garbage.

…) on failure

Downloads of tool binaries (notably wasm-opt from GitHub releases) would
fail the entire build on any transient network error. Retry the download
up to 5 attempts with exponential backoff (2s, 4s, 8s, 16s), warning
between attempts. Also truncate extracted files on write so a retry
after a partial extraction cannot leave trailing garbage.
@op
op requested a review from guybedford as a code owner September 15, 2026 12:19

@guybedford guybedford left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you.

@guybedford
guybedford enabled auto-merge (squash) September 15, 2026 15:56
@guybedford
guybedford merged commit 86092a8 into cloudflare:main Sep 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants