Skip to content

Remove file extension validation #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yavor16 merged 1 commit into from
May 28, 2025
Merged

Remove file extension validation #1639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions ...g/cloudfoundry/multiapps/controller/core/validators/parameters/FileMimeTypeValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import java.text.MessageFormat;

import jakarta.inject.Named;
import org.apache.commons.io.FilenameUtils;
import org.apache.tika.Tika;
import org.cloudfoundry.multiapps.common.SLException;
import org.cloudfoundry.multiapps.controller.core.Messages;
Expand All @@ -21,8 +20,6 @@ public class FileMimeTypeValidator {
private static final String APPLICATION_ZIP_MIME_TYPE = "application/zip";
private static final String APPLICATION_OCTET_STREAM_MIME_TYPE = "application/octet-stream";
private static final String TEXT_PLAIN_MIME_TYPE = "text/plain";
private static final String YAML_FILE_EXTENSION = "yaml";
private static final String EXTENSION_DESCRIPTOR_FILE_EXTENSION = "mtaext";
private static final Tika tika = new Tika();

public void validateMultipartFileMimeType(MultipartFile multipartFile) {
Expand Down Expand Up @@ -52,20 +49,11 @@ private String getFileMimeType(InputStream uploadedFileInputStream) throws IOExc
}

private void validateYamlFile(InputStream uploadedFileInputStream, String filename) {
validateTextFileExtension(filename);
Yaml yaml = new Yaml(new SafeConstructor(new LoaderOptions()));
try {
yaml.load(uploadedFileInputStream);
} catch (YAMLException e) {
throw new IllegalArgumentException(MessageFormat.format(Messages.THE_PROVIDED_0_FILE_IS_INVALID, filename), e);
}
}

private void validateTextFileExtension(String filename) {
String fileExtension = FilenameUtils.getExtension(filename);

if (!(YAML_FILE_EXTENSION.equals(fileExtension) || EXTENSION_DESCRIPTOR_FILE_EXTENSION.equals(fileExtension))) {
throw new IllegalArgumentException(MessageFormat.format(Messages.THE_PROVIDED_0_FILE_IS_INVALID, filename));
}
}
}
Loading