Skip module deploy with parameter#1654
Merged
Merged
Conversation
theghost5800
force-pushed
the
skipModuleDeploy
branch
from
75030e4 to
80056b5
Compare
Yavor16
requested changes
Jun 25, 2025
Comment on lines
+85
to
+86
| if (moduleToDeployHelper.shouldSkipDeploy(module)) { | ||
| if (userMessageLogger != null) { | ||
| userMessageLogger.warn(MessageFormat.format("Module \"{0}\" will be skipped during deployment", module.getName())); | ||
| } | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
There is a method in the class that does this check and logs warning. Can you reuse it and also extract the message to the Messages class
Comment on lines
+356
to
+361
| return mtaModules.contains(deployedApplication.getModuleName()) || !deploymentDescriptorModuleNames.contains( | ||
| deployedApplication.getModuleName()) || deploymentDescriptorModules.stream() | ||
| .filter(module -> module.getName() | ||
| .equals( | ||
| deployedApplication.getModuleName())) | ||
| .anyMatch(moduleToDeployHelper::shouldSkipDeploy); |
Contributor
There was a problem hiding this comment.
Can you simplify somehow this return because it's very nested
Yavor16
previously approved these changes
Jun 27, 2025
Contributor
Yavor16
left a comment
Yavor16
left a comment
There was a problem hiding this comment.
Reminder to squash before merge
ikasarov
reviewed
Jul 1, 2025
theghost5800
force-pushed
the
skipModuleDeploy
branch
from
0f6a722 to
5e0a5d2
Compare
ikasarov
approved these changes
Jul 3, 2025
Yavor16
approved these changes
Jul 3, 2025
JIRA:LMCROSSITXSADEPLOY-3196
theghost5800
force-pushed
the
skipModuleDeploy
branch
from
5e0a5d2 to
7eabe62
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA:LMCROSSITXSADEPLOY-3196
Description:
Issue: