Prep for herdr Marketplace: drop Windows platform, expand description#20
Merged
Conversation
We've never tested herdr-plus on Windows (the socket client and the sh-based build step aren't validated there), so declaring it in the manifest's platforms list is dishonest — and the Marketplace docs ask plugins to declare platforms accurately. Drop windows from both the manifest platforms and the goreleaser build matrix so we stop shipping a Windows binary we can't stand behind. Also expand the manifest description to mention Quick Actions (not just Projects) since that field is what the Marketplace index will display, and refresh the stale Phase 0 header comment now that both features ship.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Marketplace-readiness cleanup, prompted by a review against herdr's Marketplace docs.
windowsfromplatformsinherdr-plugin.toml→["linux", "macos"]. We've never tested on Windows; the socket client and thesh scripts/build.shbuild step aren't validated there. The docs say to "declareplatformshonestly, because the index will use it to show where a plugin runs."windows → ziparchive override) to releases.descriptionto mention Quick Actions, not just Projects. This is the field the Marketplace index displays.Already handled outside this PR (repo metadata)
herdr-pluginGitHub topic (the Marketplace discovery signal).Verification
go build ./...+go test ./...green.install.shhas no Windows references, so nothing breaks there.