Added service annotations to values, added services to expose built-in servers#53
Open
robertkubik-secro wants to merge 1 commit into
Open
Added service annotations to values, added services to expose built-in servers#53robertkubik-secro wants to merge 1 commit into
robertkubik-secro wants to merge 1 commit into
Conversation
Author
|
@manugarg can you please review? 🙂 |
manugarg
reviewed
Apr 30, 2026
Comment on lines
+10
to
+17
| {{- if .Values.builtinServers.http.enabled }} | ||
|
|
||
| server { | ||
| type: HTTP | ||
| http_server { | ||
| port: {{ .Values.builtinServers.http.port }} | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I this this is going to be trouble. I'd stick with just adding additional services based on values.
| # the ports. | ||
| builtinServers: | ||
| http: | ||
| enabled: false |
Contributor
There was a problem hiding this comment.
Let's just stick to adding services and trust user to add corresponding server stanzas.
Just call it additionalServices and you can say in the comment that it will be useful to expose cloudprober's built-in servers if configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.service.annotationsoption to specify annotations for a service (my case - Cilium global services)builtinServerssection to easily provision built-in servers viavalues.yamlfileThanks in advance!