Conversation
Refactor banner methods to use shared helpers (createAdView, showAdView, hideAdView, etc.) and add full MREC support following the same pattern as Android. Both formats have their own top-level methods that extract args and delegate to shared helpers parameterized by adType. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Implements iOS-side support for MREC ads and refactors banner/MREC implementations to share common ad view lifecycle helpers, aligning the iOS plugin structure with the Android plugin pattern.
Changes:
- Adds full iOS method-channel handling for MREC lifecycle APIs (create/show/hide/load/destroy/position/auto-refresh/placement/custom data).
- Refactors banner lifecycle APIs to delegate into shared ad-view helper methods.
- Introduces shared helpers (
createAdView,showAdView,hideAdView,updateAdViewPosition,loadAdView,startAdViewAutoRefresh,stopAdViewAutoRefresh,destroyAdView) used by both Banner and MREC.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Prevents accidental clicks on empty ad views by setting userInteractionEnabled = NO at creation, then enabling it in didLoadAd after a real ad is present. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Avoids redundant rootViewController lookup in the shared helper since callers already fetched and nil-checked it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Move NSNull→nil conversion into setAdViewPlacement: and setAdViewCustomData: shared helpers, reducing duplication between Banner and MREC methods - Add success log line to loadAdView: for consistency with other helpers Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createAdView,showAdView,hideAdView,updateAdViewPosition,loadAdView,startAdViewAutoRefresh,stopAdViewAutoRefresh,destroyAdView)Test plan
🤖 Generated with Claude Code