This repository was archived by the owner on Jan 30, 2026. It is now read-only.
Open
Conversation
Stop writing directly to a users homedir, so we don't leave random files lying around if the user deletes the repo. Instead use the default .tox location.
Newer versions of jingo and django-nose no longer work with older versions of Django, so pin to get tests passing again.
Python2.6 is unsupported by all major distros. And Django stopped supporting it in Django 1.6.
In the travis env getting the following error:
...
File "/home/travis/build/clouserw/tower/tower/tests/test_l10n.py", line 35, in setup
tower.activate('xx')
File "/home/travis/build/clouserw/tower/tower/__init__.py", line 104, in activate
django_trans._active.value = _activate(locale)
File "/home/travis/build/clouserw/tower/tower/__init__.py", line 130, in _activate
t.set_language(locale)
AttributeError: NullTranslations instance has no attribute 'set_language'
This appears to related to https://code.djangoproject.com/ticket/18192
* Use Jingo 0.8 for Django 1.8 * As of django/django@a5f6cbc DjangoTranslation object won't work when passed into gettext.translation. So use default gettext.GNUTranslations just like Django
futurize -1 -w -n tower/ First step in adding python3 support.
Add future as a dependency futurize -2 -w -n tower/
str(pofile) wouldn't return the contents. So instead write to BytesIO and read from there. Add a tox endpoint for py36-1.8, Django 1-7 and below doesn't support py35+
So https://github.com/brettcannon/caniusepython3 can be used to programmatically detect this works with python 3.
For python3
Add compatibility with Django 1.9+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with python 3.6