addresses bug where proc prop shows up without a process#992
Open
addresses bug where proc prop shows up without a process#992
Conversation
BeckySharp
reviewed
Mar 23, 2021
Contributor
BeckySharp
left a comment
BeckySharp
left a comment
There was a problem hiding this comment.
This checks for one edge case, but I'd rather deal with it where it originates. Is it the case that this happens when a process is promoted to theme, but the property isn't? Some other situation?
| if (tupleThemeProp.grounding.isEmpty && tupleProc.grounding.isEmpty && tupleProcProp.grounding.nonEmpty) { | ||
| val newTupleThemeProp = tupleProcProp | ||
| val newTupleProcProp = tupleProc | ||
| val newPredGrounding = PredicateGrounding(PredicateTuple(tupleTheme, newTupleThemeProp, tupleProc, |
Contributor
There was a problem hiding this comment.
tupleTheme here could be empty, right? is that desired (i.e., not checking)
Contributor
Author
There was a problem hiding this comment.
Good point...this would also give us the situation where we somehow have a theme property but no theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a bug @bgyori brought up where the SRLCompositionalGrounder will produce a grounding that includes e.g. a
theme, and aprocess propertybut noprocess. We should not have properties without the basic slot. This fix looks at the resulting tuple, checks if there is aprocess propertybut noprocess, and if so---and if there is not already atheme process---moves theprocess propertyto thetheme propertyslot.What should we do if there is a
process propertyand noprocess, but there is already atheme property? Should we just delete theprocess property?Let me know what needs changed!