Adding grammar for precondition a attributes#100
Adding grammar for precondition a attributes#100hyavari wants to merge 8 commits intoclux:masterfrom
Conversation
| // RFC 3312 precondition | ||
| push: 'precondition', | ||
| reg: /^(curr|des|conf):(qos|\S*)(?: (mandatory|optional|none|failure|unknown))? (e2e|local|remote) (none|sendrecv|send|recv)/, | ||
| names: ['state', 'type', 'strength', 'status', 'direction'], | ||
| format: function (o) { | ||
| var str = '%s:%s '; | ||
| str += o.strength != null ? '%s ' : '%v'; | ||
| str += o.status != null ? '%s ' : ''; | ||
| str += o.direction != null ? '%s ' : ''; | ||
| return str; | ||
| }, |
There was a problem hiding this comment.
This seems to be the part of the thing that you are actually adding. From a quick scan, looks sensible.
Are you able to add some tests for it?
There was a problem hiding this comment.
Hi, I tried but not sure why tests are not runnable. I'll spend more time.
|
I added parse and write tests for |
|
Thanks for this. This looks great to me. Now for the awkward part. It's actually been a while since I've had to do a release on this, and travis has shutdown since :| |
|
Hi Eirik, |
|
Hey, i've updated testing setup now, if you're able to update (nm, i can do it from here) - and it's all green - i can try to push this out later :-) |
Hi, I've just added the required grammar for parsing precondition
aattributes based on RFC 3312.Sample: