Conversation
# Details As per [RFC 8830](https://datatracker.ietf.org/doc/html/rfc8830), a media section can contain multiple `a=msid` attributes. - This is because the `MediaStreamTrack` being sent in that media section may belong to múltiple `MediaStream`. And hence, the `msid` field must be an array. Also per spec, `msid` value consists on a mandatory `id` string (which can be an `id` or '-' string) and an optional `appdata`. Within the WebRTC context, `id` is the `id` of the `MediaStream` while `appdata` is the `id` of the `MediaStreamTrack`. Also adapt the tests.
clux
left a comment
There was a problem hiding this comment.
sounds sensible to me.
checks out from the rfc
There may be multiple "msid" attributes in a single media description.
|
for purposes of semver, do you think this is a bugfix or a breaking change? :D |
I'd say this is a breaking change since any previous write usage of |
Signed-off-by: clux <sszynrae@gmail.com>
|
released in 3.0.0 |
|
Thanks a lot @clux. Next I will create a PR to update types/sdp-transform. Said that, would you accept a PR that migrates sdp-transform to TypeScript (of course the NPM published library would be transpired JS)? Another option would be to include a sdp-transform.d.ts in the repo but I find it not as reliable and more error prone than directly switching to TS. |
|
I'm already doing it... #105 (WIP) |
Details
As per RFC 8830, a media section can contain multiple
a=msidattributes. This is because theMediaStreamTrackbeing sent in that media section may belong to múltipleMediaStream. And hence, themsidfield must be an array.Also per spec,
msidvalue consists on a mandatoryidstring (which can be anidor '-' string) and an optionalappdata. Within the WebRTC context,idis theidof theMediaStreamwhileappdatais theidof theMediaStreamTrack.Also adapt the tests.