cbscore: support local registries and container reuse#29
Open
UweSchwaeke wants to merge 2 commits intoclyso:mainfrom
Open
cbscore: support local registries and container reuse#29UweSchwaeke wants to merge 2 commits intoclyso:mainfrom
UweSchwaeke wants to merge 2 commits intoclyso:mainfrom
Conversation
* what: if the return code of the rpm process is 2, check if the failure reason is that the package is already installed. * why: when reusing a container, the package might already be present. this occurs when a build runner job must be debugged. Signed-off-by: Uwe Schwaeke <uwe.schwaeke@clyso.com>
* what: add option --tls-verify to subcommands build and runner build. pass the tls-verify flag to skopeo when querying the registry. check if the return value from skopeo inspect equals "not found" (exit code 2). * why: if the image is pushed to a local container registry with a self-signed certificate, skopeo must not verify the certificate to avoid errors. current versions of skopeo (1.20.0) return exit code 2 if an image is not found. Signed-off-by: Uwe Schwaeke <uwe.schwaeke@clyso.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what:
add flag to bypass tls certificate verification for skopeo. check
skopeo return code when finding an image on the registry.
ignore rpm install failure if the package is already installed.
why:
local container registries don't need valid tls certificates or may
use self-signed ones. skopeo verifies certificates by default unless
--tls-verify=false is passed.
note:
this also makes the container reusable for debugging. currently,
rpm install fails with return code 2 if the package is already installed.
in a production environment, containers are generated from scratch,
so this issue does not arise.