Skip to content

Drop ROOT GLEW root#10395

Merged
smuzaffar merged 3 commits intoIB/CMSSW_16_1_X/rootmasterfrom
root6-droprootglew
Mar 7, 2026
Merged

Drop ROOT GLEW root#10395
smuzaffar merged 3 commits intoIB/CMSSW_16_1_X/rootmasterfrom
root6-droprootglew

Conversation

@smuzaffar
Copy link
Copy Markdown
Contributor

Latest root has remove the buildin glew ( root-project/root#20013 ). This PR proposes to drop the rootglew tool from cmssw

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 6, 2026

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_16_1_X/rootmaster.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

lets see if cmssw really need GLEW (even without root dropping it)

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 6, 2026

Pull request #10395 was updated.

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

@cms-sw cms-sw deleted a comment from cmsbuild Mar 6, 2026
@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 6, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 6, 2026

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a0a5e/51803/summary.html
COMMIT: 6d3627b
CMSSW: CMSSW_16_1_ROOT6_X_2026-03-05-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10395/51803/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 261 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 13560 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4180442
  • DQMHistoTests: Total failures: 191405
  • DQMHistoTests: Total nulls: 14
  • DQMHistoTests: Total successes: 3989003
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 472.977 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 17034.0 ): 1.737 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 18434.0,... ): 112.246 KiB GEM/Digis
  • DQMHistoSizes: changed ( 18434.0,... ): 59.098 KiB RPC/AllHits
  • DQMHistoSizes: changed ( 18434.0,... ): 58.570 KiB RPC/Muon
  • DQMHistoSizes: changed ( 18434.0,... ): 1.978 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 18434.0,... ): 0.703 KiB RPC/RPCRecHitV
  • DQMHistoSizes: changed ( 18634.0 ): 6.050 KiB SiStrip/MechanicalView
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 3 / 51 workflows

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test using full cmssw

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 7, 2026

Pull request #10395 was updated.

@smuzaffar smuzaffar merged commit 204d4a1 into IB/CMSSW_16_1_X/rootmaster Mar 7, 2026
6 of 7 checks passed
@smuzaffar smuzaffar deleted the root6-droprootglew branch March 11, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants