Open
Conversation
Contributor
|
My plan has always been that inside the container, /host always contains the Redemption code, and the code you repair lives somewhere else, such as /data. This is useful when we develop Redemption, we share the Redemption code between host and container, so we can edit code on the host and run on the container. It is necessary if you use the 'prereq' or 'test' containers, which does not contain the Redemption code. However, sharing /host is less valuable if you are not developing the Redemption code. I will make this more explicit in the top-level README file. Thanks for marking up the other 'docker run' commands. I will verify that they are consistent with the README file instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found 13 instances where "docker run --rm -v ${PWD}:/host" or something similar exist in the redemption project.
I put a [!WARNING] one line above all occurrences to make these easy to find.
I might be wrong, but I think mounting to /host in the redemption docker may cause some issues.
I'll demonstrate an example:
Lets say I have a report.xml file from cppchecker and I want to run alerts2input.py
I will run the command:

sudo docker run -it --rm -v ~/Downloads/myCode/:/host -w /host docker.cc.cert.org/redemption/prereq bashAs you can see from the above picture, it's not possible to go to /host/code/analysis/alerts2input.py because the /host directory is replaced with the myCode directory.