feat(deps): OCI Akua-package deps — accept package.k as KclModule marker#39
Merged
Conversation
`find_package_root` now accepts either `kcl.mod` (kpm-published) or `package.k` (Akua-published) as a `KclModule` marker. Annotation detection (`detect_package`) and filesystem detection (`detect_kind`) already recognize `dev.akua.*` annotations + `akua.toml + package.k` directories from PR #34; the missing piece was the cache-root descent step that finalizes a fetched OCI artifact. End result: `[dependencies] upstream = { oci = "...", version = "..." }` where the artifact is an Akua-published OCI package now resolves through to the cached directory and lands as a `KclModule` dep. Also fixes a pre-existing test-only build break in `verbs/render.rs` where the `args(...)` test helper was missing the `debug` field added in PR #33. Test plan: - `cargo test -p akua-core --features oci-fetch --lib oci_fetcher::tests` — 12/12 (new: `extract_blob_unpacks_akua_published_plain_tar`) - `cargo test --workspace --all-features` — green - `cargo clippy --workspace --all-features` — clean
robinbraemer
added a commit
that referenced
this pull request
May 7, 2026
…scape Per-code page meta descriptions and the index page summary divs were re-escaping already-escaped HTML, turning `<alias>` into `&lt;alias&gt;` which browsers render as the literal text `<alias>`. The body content was always correct (it goes through renderInline once); only the contexts that re-fed through `escape()` after `stripTags` broke. Fix: stripTags now also unescapes < / > / " / ' / & back to plain text after stripping tags, so downstream escape() runs once on plain text rather than double-escaping HTML entities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_package_rootaccepts eitherkcl.mod(kpm) orpackage.k(Akua-published) as aKclModulemarker. Annotation detection + filesystem detection already accepted Akua artifacts (PR feat(deps): Akua-package path-deps + lock-time import-kind validation #34); this is the cache-descent step that closes the loop.verbs/render.rs::argstest helper missing thedebugfield added in PR fix(render): E_PATH_ESCAPE suggests vendor-or-declare remediation #33).Closes spike-1 follow-up #481 (extracted from PR #34).
Test plan
cargo test -p akua-core --features oci-fetch --lib oci_fetcher::tests— 12/12 (new:extract_blob_unpacks_akua_published_plain_tar)cargo test --workspace --all-features— greencargo clippy --workspace --all-features— clean