fix: export KCL boolean defaults as JSON booleans#63
Merged
Conversation
Rationale: Codezero package input schemas use KCL boolean defaults for UI controls, and the exported JSON Schema must expose those defaults as JSON booleans rather than strings.
Rejected: Treating every KCL default as JSON text first leaves True/False as strings because KCL boolean literals are capitalized while JSON booleans are lowercase.
Risk: Narrow parser change only special-cases KCL True/False before existing JSON parsing fallback.
Tested:\n- cargo test -p akua-core export::tests\n- cargo run -p akua-cli -- export --package /Users/robin/Developer/cnap-tech/codezero-package/package.k --format json-schema --out /tmp/codezero-fixed-schema/input.schema.json\n- jq '{runtime_enabled: .properties.runtime_enabled.default, velorum_enabled: .properties.velorum_enabled.default}' /tmp/codezero-fixed-schema/input.schema.json\n- git diff --check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
True/Falsedefaults as JSON booleansTest Plan