feat(bias): per-light night_brightness override for the night_look join - #14
Merged
Merged
Conversation
The idle=circadian -> night_look join (251af28) gives every viewing light the exact same look, but physical mounts differ: an indirect uplight behind objects needs more lumens than a direct fixture to register as visible at all, let alone the same. Live report 2026-08-08: the couch lightstrip sits under a console table behind books and bounces light upward -- at night_look's shared 1% it was imperceptible. bias.lights[*].night_brightness (optional, 0-100) overrides just the brightness this light uses when joining night_look -- keeps night_look's colour (still reads as the same theme) but lets each fixture be calibrated for how/where it's actually mounted. Lights without an override are unaffected, same as before. 1 new pure test (override applies + a light with no override stays unchanged, both checked together), verified to fail on the pre-fix code (branch disabled, ran red, restored). Full suite (398 tests) + mypy clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-landing e8d776d through a proper PR (originally direct-pushed to main,
reverted in #9).
The idle=circadian -> night_look join (#13) gives every viewing light the
exact same look, but physical mounts differ: an indirect uplight behind
objects needs more lumens than a direct fixture to register as visible at
all. Live report 2026-08-08: the couch lightstrip sits under a console
table behind books and bounces light upward — at night_look's shared 1% it
was imperceptible.
bias.lights[*].night_brightness(optional, 0-100) overrides just thebrightness this light uses when joining night_look — keeps night_look's
colour but lets each fixture be calibrated for its mount.
1 new pure test, verified to fail on the pre-fix code (branch disabled, ran
red, restored).