Skip to content

fix(mcp): inherit project mcp overrides when creating new sessions - #294

Merged
co-l merged 1 commit into
co-l:developfrom
JamesDAdams:fix/mcp-session-bug
Sep 2, 2026
Merged

fix(mcp): inherit project mcp overrides when creating new sessions#294
co-l merged 1 commit into
co-l:developfrom
JamesDAdams:fix/mcp-session-bug

Conversation

@JamesDAdams

Copy link
Copy Markdown
Contributor

Summary

  • Fix MCP session override inheritance: new sessions now properly inherit project-level disabled MCP servers and global MCP defaults.
  • Centralize MCP override calculation in session-overrides.ts (computeDisabledServersForProject, initSessionMcpOverrides).
  • Preserve disabled MCP servers when forking sessions (forkSession) and cleanup on delete (deleteSession).
  • Fix ProjectSettingsModal payload to send empty overrides when dirty so settings can be cleared.

AI-Enhanced Development

Tell what models helped shape this PR:

  • AI Models: Gemini 3.7 Flash

Cache Impact

Does this PR affect anything cached — system prompts, tool definitions, skills, or other context?

  • Yes tool definitions and dynamic context now correctly reflect project MCP configuration on session start.

@co-l
co-l force-pushed the fix/mcp-session-bug branch from f089033 to 71c68f1 Compare September 2, 2026 18:17
@co-l
co-l merged commit 862e1c0 into co-l:develop Sep 2, 2026
6 checks passed
@co-l

co-l commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Merged, will be released in v2.0.136

AI-summary

  • Rebased the PR onto latest develop and resolved 2 conflicts (session-create route and ProjectSettingsModal), keeping the newer buildSessionCreatedMessage broadcast and the mcpDirty clearing fix
  • Verified the full unit suite (5108 passed), typecheck, lint, format and duplicate clean, plus MCP/session e2e green (36 tests)
  • Confirmed the removed getAllSessionOverrides has no remaining references
  • Pushed the rebased branch to the contributor's fork so the PR merges cleanly
  • Squash-merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants