Skip to content

Handle 404 errors for Limes API #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SoWieMarkus merged 2 commits into from
Feb 11, 2026
Merged

Handle 404 errors for Limes API #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abb55e5
Handle 404 errors for deleted projects in getCommitments
SoWieMarkus Feb 10, 2026
cd71b9a
Improve logging message for 404 errors in getCommitments
SoWieMarkus Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions internal/knowledge/datasources/plugins/openstack/limes/limes_api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,14 @@ func (api *limesAPI) getCommitments(ctx context.Context, project identity.Projec
return nil, err
}
defer resp.Body.Close()

// This can happen if a project was deleted after we fetched the list of projects but before we fetched the commitments for the project.
// In this case, we can simply ignore the error and return an empty list of commitments for the project.
if resp.StatusCode == http.StatusNotFound {
slog.Warn("limes returned 404 for project, skipping", "projectID", project.ID, "domainID", project.DomainID)
return []Commitment{}, nil
}

if resp.StatusCode != http.StatusOK {
return nil, fmt.Errorf("unexpected status code: %d", resp.StatusCode)
}
Expand Down
11 changes: 11 additions & 0 deletions internal/knowledge/datasources/plugins/openstack/limes/limes_api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,15 @@ func TestLimesAPI_GetAllCommitments_MultipleProjects(t *testing.T) {
}
})

handler.HandleFunc("/v1/domains/domain1/projects/project-deleted/commitments", func(w http.ResponseWriter, r *http.Request) {
w.Header().Add("Content-Type", "application/json")
w.WriteHeader(http.StatusNotFound)
_, err := w.Write([]byte(`{"error": "project not found"}`))
if err != nil {
t.Fatalf("failed to write response: %v", err)
}
})

server := httptest.NewServer(handler)
defer server.Close()

Expand All @@ -162,6 +171,8 @@ func TestLimesAPI_GetAllCommitments_MultipleProjects(t *testing.T) {
projects := []identity.Project{
{ID: "project1", DomainID: "domain1"},
{ID: "project2", DomainID: "domain1"},
// Returns a 404, should be handled gracefully and not cause the entire API call to fail.
{ID: "project-deleted", DomainID: "domain1"},
}
commitments, err := api.GetAllCommitments(ctx, projects)
if err != nil {
Expand Down