Split up shared config to improve self-sustainedness of modules#516
Merged
PhilippMatthes merged 2 commits intomainfrom Feb 12, 2026
Merged
Split up shared config to improve self-sustainedness of modules#516PhilippMatthes merged 2 commits intomainfrom
PhilippMatthes merged 2 commits intomainfrom
Conversation
PhilippMatthes
requested review from
SoWieMarkus,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
Contributor
Test Coverage ReportTest Coverage 📊: 67.9% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was technical debt in that some of the controllers didn't even need a config and it was just passed for no reason. Now it is more transparant which component needs which config options, which also makes it easier to plug in new components without having to supply e.g. sso certificate secrets or keystone secrets.