Conversation
umswmayj
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer and
mblos
as code owners
mblos
approved these changes
Feb 17, 2026
api/v1alpha1/reservation_types.go
Outdated
| // - For Nova: the hypervisor hostname | ||
| // - For Pods: the node name | ||
| // +kubebuilder:validation:Optional | ||
| ObservedHost string `json:"observedHost,omitempty"` |
Collaborator
There was a problem hiding this comment.
no strong opinion
Suggested change
| ObservedHost string `json:"observedHost,omitempty"` | |
| Host string `json:"observedHost,omitempty"` |
mblos
reviewed
Feb 17, 2026
| // The project ID to reserve for. | ||
| // ResourceGroup is the group/category of the resource (e.g., "hana_medium_v2"). | ||
| // +kubebuilder:validation:Optional | ||
| ResourceGroup string `json:"resourceGroup,omitempty"` |
Collaborator
There was a problem hiding this comment.
why is ResourceGroup also on root level? Required for more use cases than CRs?
Collaborator
Author
There was a problem hiding this comment.
It is not on root the diff is just not great
Contributor
Test Coverage ReportTest Coverage 📊: 68.7% |
Member
|
Cool 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.