Hypervisor: Always reflect node annotations in hypervisor-spec#186
Merged
Hypervisor: Always reflect node annotations in hypervisor-spec#186
Conversation
notandy
requested changes
Dec 2, 2025
fwiesel
force-pushed
the
sync-hypervisor-nodes
branch
2 times, most recently
from
6317213 to
3c16538
Compare
fwiesel
changed the title
fwiesel
force-pushed
the
sync-hypervisor-nodes
branch
2 times, most recently
from
571110e to
ddbce14
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Only syncing on creation introduced a race-condition: The node may have been created, but the labels and annotations get synced later. To fix that, always sync the annotations, provided they are set. Should another CRD in the cluster manage these specs via another operator, we simply need to remove the annotations first.
notandy
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only syncing on creation introduced a race-condition: The node may have been created, but the labels and annotations get synced later.
To fix that, always sync the annotations, provided they are set. Should another CRD in the cluster manage these specs via another operator, we simply need to remove the annotations first.