Merged
Conversation
Contributor
fwiesel
commented
Dec 15, 2025
fwiesel
commented
- This adds some basic happy-path tests
- It takes care of removing the host from all aggregates, except the ones needed for the test
- Finally, it removes the hardcoded flavor for the smallest matching flavor (currently only flavors not targeting a specific hypervisor).
The main loop is retrying already.
If the offboarding failed for any reason, we might be have left-over associations with other aggregates. For robustness reasons, let's handle that case here as well.
The logic is fairly straight forward, find the smallest flavor that hasn't the hypervisor-type fixed. We might want to adjust that eventually to maybe match the hypervisor-type, but in our environment we have a tiny test-flavor that fits that description.
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
mchristianl
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.