Skip to content

Maintenance: Fix summary when evicting#238

Merged
fwiesel merged 1 commit intomainfrom
fix-maintenance-summary
Feb 13, 2026
Merged

Maintenance: Fix summary when evicting#238
fwiesel merged 1 commit intomainfrom
fix-maintenance-summary

Conversation

@fwiesel
Copy link
Contributor

@fwiesel fwiesel commented Feb 13, 2026

Before this change, the summary was setting the hypervisor summary condition 'Ready' to the same value, regardless if the eviction was ongoing or not.
In both cases, the description and reason was saying evicted, which is incorrect. This fixes the reason and message to evicting when the eviction is still ongoing.

Before this change, the summary was setting the hypervisor summary
condition 'Ready' to the same value, regardless if the eviction
was ongoing or not.
In both cases, the description and reason was saying *evicted*,
which is incorrect. This fixes the reason and message to
*evicting* when the eviction is still ongoing.
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1 0.00% (ø)
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 56.03% (+0.05%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1/hypervisor_types.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_maintenance_controller.go 71.95% (+0.35%) 82 (+1) 59 (+1) 23 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_maintenance_controller_test.go

@fwiesel fwiesel merged commit 8267927 into main Feb 13, 2026
6 checks passed
@fwiesel fwiesel deleted the fix-maintenance-summary branch February 13, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants