When Using Prefixes With Deletion Copies Objects are Deleted When They Shouldn't Be#116
Open
kylec32 wants to merge 2 commits intocobbzilla:2.1-stablefrom
Open
When Using Prefixes With Deletion Copies Objects are Deleted When They Shouldn't Be#116kylec32 wants to merge 2 commits intocobbzilla:2.1-stablefrom
kylec32 wants to merge 2 commits intocobbzilla:2.1-stablefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I have started to use additional features of the library I have noticed that if I include prefixes along with the
--delete-removedI noticed that the objects would be deleted before they were copied over again. This of course defeats much of the purpose of doing the sync as well as inflates the site of the bucket when versioning is enabled. Digging in it turned outto be small issues that are represented in this PR to fix the issue.